Versions Compared

Old Version 12

changes.mady.by.user Chris Hyzer (upenn.edu)

Saved on

compared with

New Version 13

changes.mady.by.user Chris Hyzer (upenn.edu)

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

StepSummaryDescription
  1. Add the fields/getters
In the bean, add getters and setters and fields


Code Block
  /**
   * when this group was removed from grouper
   */
  private Timestamp inGrouperEnd;

  /**
   * when this group was removed from grouper
   * @return
   */
  public Timestamp getInGrouperEnd() {
    return inGrouperEnd;
  }

  /**
   * when this group was removed from grouper
   * @param inGrouperEnd
   */
  public void setInGrouperEnd(Timestamp inGrouperEnd) {
    this.inGrouperEnd = inGrouperEnd;
  }


2. Scan class for more workIf all bean properties are used elsewhere in class,
add those too


Code Block
clone() {
    gcGrouperSyncGroup.id = this.id;
    gcGrouperSyncGroup.inGrouperDb = this.inGrouperDb;
    gcGrouperSyncGroup.inGrouperEnd = this.inGrouperEnd;


3. Edit the hbm mapping fileLook at HBM and edit it accordingly


Code Block
    <property name="inGrouperEnd" column="in_grouper_end" type="timestamp"/>


4. Add column if upgradeIf this is an upgrade, add the column to the table


Code Block
    if (!buildingToThisVersionAtLeast(ddlVersionBean)) {
      return;
    }

    // if building from scratch its already got it
    if(buildingFromScratch(ddlVersionBean)) {
      return;
    }
    
    if (ddlVersionBean.didWeDoThis("v2_5_38_addGrouperSyncStartColumns", true)) {
      return;
    }
      GrouperDdlUtils.ddlutilsFindOrCreateColumn(grouperSyncGroupTable, "in_grouper_end", 
          Types.TIMESTAMP, "1", false, false);


5. Add in table if starting anewIf loading DDL from scratch, the column should
be added when the table is created, not as an 
alter table.  But only do this if building passed
the version where it is added


Code Block
      if (GrouperDdl2_5_38.buildingToThisVersionAtLeast(ddlVersionBean)) {

        GrouperDdlUtils.ddlutilsFindOrCreateColumn(grouperSyncGroupTable, "in_grouper_end", 
            Types.TIMESTAMP, "10", false, false);

      }


6. Similarly add commentsAdd comments to all objects for postgres/oracle


Code Block
    GrouperDdlUtils.ddlutilsColumnComment(ddlVersionBean, "grouper_sync_group", "in_grouper_end", "when this was taken out of grouper");


7. For each DB, install ddl utilsDroponly all objects, then do a -registry -check -useDdlUtilsThis will generate the full generated DDL script
7a. Note, a unit test makes this a lot faster

8. Merge changes to static dllMerge changes from that full script to the 
conf/ddl/GrouperDdl_Grouper_install_<db>.sql

For each DB

Dont copy the whole script in, just the thing that changed

Code Block
    in_target_start TIMESTAMP,
    in_target_end TIMESTAMP,
    provisionable_start TIMESTAMP,


8a. Add an upgrade script for each databaseconf/ddl/GrouperDdl_Grouper_XX_upgradeTo_XX_<dbVendor>.sqlSee others for example, and pay attention to bottom version numbers
9. Correct bottom version

At the bottom of the file is an insert statement,
make sure the version is correct

For each DB

e.g. for hsql:

Code Block
insert into grouper_ddl (id, object_name, db_version, last_updated, history) values 
('c08d3e076fdb4c41acdafe5992e5dc4d', 'Grouper', 35, to_char(CURRENT_TIMESTAMP, 'YYYY/MM/DD HH24:mi:DD'), 
to_char(CURRENT_TIMESTAMP, 'YYYY/MM/DD HH24:mi:DD') || ': upgrade Grouper from V0 to V35, ');
commit;


10. Try an install using the static file

just start grouper shell (with auto ddl)

For each DB

Make sure the new column / comment is there
11. Get the DB to the previous 

-droponly.  Then you can use the previous full SQL from git,
make sure the grouper ddl version at bottom of file is correct (previous version)

For each DB

Run that SQL in your DB client (e.g. dbeaver).  See the column isnt there
12. Upgrade using ddl utils
(dont run script)

-registry -check -useDdlUtils

For each DB.  Note, you can do this twice,
once before the changes, once after, and compare

The output of that script is a mess.  We want the diff to be minimal.  Use what you can and craft an upgrade script.  Dont worry about the order of columns.  If ddlutils says to add a column after another column, ignore that part

Code Block
ALTER TABLE GROUPER_SYNC_GROUP
    ADD COLUMN in_grouper_end TIMESTAMP;


15. Deep ddl check

-registry -deep should report a missing column

For each DB


14. Upgrade with static DDL

just start grouper shell (with auto ddl)

For each DB

Make sure the new column / comment is there
16. Deep ddl check

-registry -deep should report the DB is up to date

For each DB


...